-
Notifications
You must be signed in to change notification settings - Fork 311
Report config_id for Hands Off Config files #9299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Code coverage: total 57.29%, base diff -0.03%, patch 83.87% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: d889003 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~d88900356b, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051767
Total [baseline] (10.759 s) : 0, 10759261
Agent [candidate] (1.044 s) : 0, 1044114
Total [candidate] (10.778 s) : 0, 10777810
section appsec
Agent [baseline] (1.228 s) : 0, 1228251
Total [baseline] (10.815 s) : 0, 10815080
Agent [candidate] (1.232 s) : 0, 1232127
Total [candidate] (10.846 s) : 0, 10845873
section iast
Agent [baseline] (1.186 s) : 0, 1186028
Total [baseline] (10.895 s) : 0, 10895254
Agent [candidate] (1.194 s) : 0, 1193770
Total [candidate] (11.011 s) : 0, 11011388
section profiling
Agent [baseline] (1.194 s) : 0, 1193589
Total [baseline] (10.897 s) : 0, 10896816
Agent [candidate] (1.209 s) : 0, 1208686
Total [candidate] (10.903 s) : 0, 10902678
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~d88900356b, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (737.587 ms) : 0, 737587
BytebuddyAgent [candidate] (730.09 ms) : 0, 730090
GlobalTracer [baseline] (243.794 ms) : 0, 243794
GlobalTracer [candidate] (241.519 ms) : 0, 241519
AppSec [baseline] (30.299 ms) : 0, 30299
AppSec [candidate] (30.091 ms) : 0, 30091
Debugger [baseline] (6.08 ms) : 0, 6080
Debugger [candidate] (6.012 ms) : 0, 6012
Remote Config [baseline] (656.27 µs) : 0, 656
Remote Config [candidate] (648.799 µs) : 0, 649
Telemetry [baseline] (10.737 ms) : 0, 10737
Telemetry [candidate] (13.35 ms) : 0, 13350
section appsec
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (758.751 ms) : 0, 758751
BytebuddyAgent [candidate] (762.641 ms) : 0, 762641
GlobalTracer [baseline] (236.508 ms) : 0, 236508
GlobalTracer [candidate] (236.568 ms) : 0, 236568
IAST [baseline] (23.603 ms) : 0, 23603
IAST [candidate] (23.764 ms) : 0, 23764
AppSec [baseline] (168.111 ms) : 0, 168111
AppSec [candidate] (169.986 ms) : 0, 169986
Debugger [baseline] (8.87 ms) : 0, 8870
Debugger [candidate] (5.766 ms) : 0, 5766
Remote Config [baseline] (620.545 µs) : 0, 621
Remote Config [candidate] (630.833 µs) : 0, 631
Telemetry [baseline] (9.153 ms) : 0, 9153
Telemetry [candidate] (10.043 ms) : 0, 10043
section iast
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (856.815 ms) : 0, 856815
BytebuddyAgent [candidate] (863.109 ms) : 0, 863109
GlobalTracer [baseline] (234.377 ms) : 0, 234377
GlobalTracer [candidate] (235.059 ms) : 0, 235059
IAST [baseline] (26.738 ms) : 0, 26738
IAST [candidate] (28.708 ms) : 0, 28708
AppSec [baseline] (28.298 ms) : 0, 28298
AppSec [candidate] (26.912 ms) : 0, 26912
Debugger [baseline] (8.329 ms) : 0, 8329
Debugger [candidate] (8.213 ms) : 0, 8213
Remote Config [baseline] (577.125 µs) : 0, 577
Remote Config [candidate] (599.609 µs) : 0, 600
Telemetry [baseline] (8.254 ms) : 0, 8254
Telemetry [candidate] (8.405 ms) : 0, 8405
section profiling
crashtracking [baseline] (1.406 ms) : 0, 1406
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (759.731 ms) : 0, 759731
BytebuddyAgent [candidate] (769.979 ms) : 0, 769979
GlobalTracer [baseline] (222.649 ms) : 0, 222649
GlobalTracer [candidate] (224.011 ms) : 0, 224011
AppSec [baseline] (29.832 ms) : 0, 29832
AppSec [candidate] (30.506 ms) : 0, 30506
Debugger [baseline] (6.211 ms) : 0, 6211
Debugger [candidate] (6.361 ms) : 0, 6361
Remote Config [baseline] (695.562 µs) : 0, 696
Remote Config [candidate] (698.818 µs) : 0, 699
Telemetry [baseline] (15.236 ms) : 0, 15236
Telemetry [candidate] (16.385 ms) : 0, 16385
ProfilingAgent [baseline] (108.365 ms) : 0, 108365
ProfilingAgent [candidate] (109.196 ms) : 0, 109196
Profiling [baseline] (108.987 ms) : 0, 108987
Profiling [candidate] (109.847 ms) : 0, 109847
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~d88900356b, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044525
Total [baseline] (8.6 s) : 0, 8600080
Agent [candidate] (1.043 s) : 0, 1042757
Total [candidate] (8.594 s) : 0, 8594235
section iast
Agent [baseline] (1.175 s) : 0, 1174543
Total [baseline] (9.337 s) : 0, 9337320
Agent [candidate] (1.176 s) : 0, 1176430
Total [candidate] (9.31 s) : 0, 9310178
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~d88900356b, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.423 ms) : 0, 1423
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (731.225 ms) : 0, 731225
BytebuddyAgent [candidate] (729.16 ms) : 0, 729160
GlobalTracer [baseline] (241.571 ms) : 0, 241571
GlobalTracer [candidate] (241.139 ms) : 0, 241139
AppSec [baseline] (30.004 ms) : 0, 30004
AppSec [candidate] (29.875 ms) : 0, 29875
Debugger [baseline] (5.992 ms) : 0, 5992
Debugger [candidate] (6.036 ms) : 0, 6036
Remote Config [baseline] (650.721 µs) : 0, 651
Remote Config [candidate] (653.739 µs) : 0, 654
Telemetry [baseline] (12.682 ms) : 0, 12682
Telemetry [candidate] (13.558 ms) : 0, 13558
section iast
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (848.006 ms) : 0, 848006
BytebuddyAgent [candidate] (849.593 ms) : 0, 849593
GlobalTracer [baseline] (232.277 ms) : 0, 232277
GlobalTracer [candidate] (232.732 ms) : 0, 232732
IAST [baseline] (28.074 ms) : 0, 28074
IAST [candidate] (27.986 ms) : 0, 27986
AppSec [baseline] (26.74 ms) : 0, 26740
AppSec [candidate] (26.652 ms) : 0, 26652
Debugger [baseline] (8.228 ms) : 0, 8228
Debugger [candidate] (8.241 ms) : 0, 8241
Remote Config [baseline] (582.954 µs) : 0, 583
Remote Config [candidate] (574.202 µs) : 0, 574
Telemetry [baseline] (8.222 ms) : 0, 8222
Telemetry [candidate] (8.271 ms) : 0, 8271
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~d88900356b, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section baseline
no_agent (37.354 ms) : 37054, 37655
. : milestone, 37354,
appsec (47.002 ms) : 46601, 47403
. : milestone, 47002,
code_origins (42.352 ms) : 41990, 42714
. : milestone, 42352,
iast (45.677 ms) : 45269, 46084
. : milestone, 45677,
profiling (48.698 ms) : 48216, 49181
. : milestone, 48698,
tracing (42.462 ms) : 42105, 42820
. : milestone, 42462,
section candidate
no_agent (36.351 ms) : 36062, 36640
. : milestone, 36351,
appsec (45.606 ms) : 45204, 46008
. : milestone, 45606,
code_origins (46.332 ms) : 45949, 46714
. : milestone, 46332,
iast (46.184 ms) : 45782, 46587
. : milestone, 46184,
profiling (49.255 ms) : 48800, 49710
. : milestone, 49255,
tracing (42.917 ms) : 42557, 43278
. : milestone, 42917,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~d88900356b, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section baseline
no_agent (4.307 ms) : 4252, 4361
. : milestone, 4307,
iast (9.392 ms) : 9237, 9546
. : milestone, 9392,
iast_FULL (14.017 ms) : 13730, 14305
. : milestone, 14017,
iast_GLOBAL (10.118 ms) : 9938, 10298
. : milestone, 10118,
profiling (8.918 ms) : 8780, 9056
. : milestone, 8918,
tracing (7.906 ms) : 7792, 8019
. : milestone, 7906,
section candidate
no_agent (4.3 ms) : 4244, 4356
. : milestone, 4300,
iast (9.363 ms) : 9211, 9515
. : milestone, 9363,
iast_FULL (13.893 ms) : 13615, 14170
. : milestone, 13893,
iast_GLOBAL (10.581 ms) : 10394, 10769
. : milestone, 10581,
profiling (9.432 ms) : 9279, 9586
. : milestone, 9432,
tracing (7.873 ms) : 7759, 7987
. : milestone, 7873,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~d88900356b, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.675 ms) : 3460, 3890
. : milestone, 3675,
iast (2.202 ms) : 2139, 2265
. : milestone, 2202,
iast_GLOBAL (2.255 ms) : 2191, 2319
. : milestone, 2255,
profiling (2.063 ms) : 2012, 2115
. : milestone, 2063,
tracing (2.024 ms) : 1974, 2073
. : milestone, 2024,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.681 ms) : 3462, 3900
. : milestone, 3681,
iast (2.215 ms) : 2152, 2279
. : milestone, 2215,
iast_GLOBAL (2.251 ms) : 2188, 2314
. : milestone, 2251,
profiling (2.062 ms) : 2010, 2114
. : milestone, 2062,
tracing (2.03 ms) : 1980, 2079
. : milestone, 2030,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~d88900356b, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section baseline
no_agent (14.93 s) : 14930000, 14930000
. : milestone, 14930000,
appsec (14.93 s) : 14930000, 14930000
. : milestone, 14930000,
iast (18.72 s) : 18720000, 18720000
. : milestone, 18720000,
iast_GLOBAL (17.839 s) : 17839000, 17839000
. : milestone, 17839000,
profiling (15.514 s) : 15514000, 15514000
. : milestone, 15514000,
tracing (14.938 s) : 14938000, 14938000
. : milestone, 14938000,
section candidate
no_agent (15.538 s) : 15538000, 15538000
. : milestone, 15538000,
appsec (14.891 s) : 14891000, 14891000
. : milestone, 14891000,
iast (18.213 s) : 18213000, 18213000
. : milestone, 18213000,
iast_GLOBAL (18.096 s) : 18096000, 18096000
. : milestone, 18096000,
profiling (16.067 s) : 16067000, 16067000
. : milestone, 16067000,
tracing (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
|
…va into mtoff/scfg_config-id
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
Reports config_id in configuration telemetry payloads when the origin is a stable config file.
Passing system tests: DataDog/system-tests#5062
Motivation
https://datadoghq.atlassian.net/browse/APMAPI-1354
Additional Notes
This PR is newly causing system-test
test_app_started_client_configuration
to fail because the test expectstelemetry_heartbeat_interval
to report value"2"
but tracer is reporting"2.0"
. I cannot figure out why the changes in this PR cause the failure; the tracer has stored this config as a float since before these changes.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]